remove unnecessary utf-8 header in .py files #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelorji
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 89 89
Lines 7935 7935
=======================================
Hits 5712 5712
Misses 2223 2223 ☔ View full report in Codecov by Sentry. |
Signed-off-by: samuel orji <[email protected]>
samuelorji
force-pushed
the
chore/issue-613
branch
from
56a57a6 to
bddee0c
Compare
dblock
requested changes
Nov 24, 2023
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Changed | |||
| ### Deprecated | |||
| ### Removed | |||
| - Removed Unnecessary `# -*- coding: utf-8 -*-` headers from .py files | |||
There was a problem hiding this comment.
Make this look like other changelog lines, lowercase unnecessary and add a link to the PR.
Signed-off-by: samuel orji <[email protected]>
dblock
approved these changes
Nov 24, 2023
dblock
pushed a commit
that referenced
this pull request
Nov 28, 2023
) (#617) * License tools: remove utf-8 coding declaration from license_headers.py check/fix script; since #615 it is no longer used in the library's codebase UTF-8 is the default encoding used to read source code files for Python3 - see https://docs.python.org/3/howto/unicode.html#unicode-literals-in-python-source-code Signed-off-by: James Addison <[email protected]> * Cleanup: remove utf-8 coding declaration from the license_headers.py script itself Signed-off-by: James Addison <[email protected]> * Update CHANGELOG.md Signed-off-by: James Addison <[email protected]> --------- Signed-off-by: James Addison <[email protected]>
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
* remove unnecessary utf-8 header in .py files Signed-off-by: samuel orji <[email protected]> * review feedback: add link to changelog Signed-off-by: samuel orji <[email protected]> --------- Signed-off-by: samuel orji <[email protected]> Signed-off-by: roma2023 <[email protected]>
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…pensearch-project#615) (opensearch-project#617) * License tools: remove utf-8 coding declaration from license_headers.py check/fix script; since opensearch-project#615 it is no longer used in the library's codebase UTF-8 is the default encoding used to read source code files for Python3 - see https://docs.python.org/3/howto/unicode.html#unicode-literals-in-python-source-code Signed-off-by: James Addison <[email protected]> * Cleanup: remove utf-8 coding declaration from the license_headers.py script itself Signed-off-by: James Addison <[email protected]> * Update CHANGELOG.md Signed-off-by: James Addison <[email protected]> --------- Signed-off-by: James Addison <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Unnecessary
# -*- coding: utf-8 -*-headers from .py filesIssues Resolved
#613
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.